Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore default methods in StrictUnusedVariable #2070

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

pkoenig10
Copy link
Member

@pkoenig10 pkoenig10 commented Feb 5, 2022

Like abstract methods, default methods often have unused variables. These methods are intended to be overridden by implementations that may need those variables.

For example, a common pattern is something that looks like:

interface ErrorHandler {
    default void onError(Throwable throwable) {}
}

@changelog-app
Copy link

changelog-app bot commented Feb 5, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

StrictUnusedVariable no longer flags parameters of default methods.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from robert3005 February 5, 2022 02:53
@bulldozer-bot bulldozer-bot bot merged commit 11f31b0 into develop Feb 7, 2022
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/default branch February 7, 2022 19:29
@svc-autorelease
Copy link
Collaborator

Released 4.68.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Feb 7, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.68.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Remove support for running errorprone witth java 8 target compatibility | palantir/gradle-baseline#2061 |
| Improvement | `StrictUnusedVariable` no longer flags parameters of default methods. | palantir/gradle-baseline#2070 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants