Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow class types in DangerousIdentityKey #2036

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

pkoenig10
Copy link
Member

Before this PR

Using Class as a map or set key is disallowed by DangerousIdentityKey

After this PR

Using Class as a map or set key is not disallowed by DangerousIdentityKey

There should only ever be one instance of a given Class type. Equality comparisons are only way to perform exact class comparison (things like instanceof consider inheritance).

@changelog-app
Copy link

changelog-app bot commented Jan 13, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

DangerousIdentityKey now allows Class to be used as a map or set key.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers January 13, 2022 17:44
@bulldozer-bot bulldozer-bot bot merged commit ad9a16e into develop Jan 13, 2022
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/classIdentityKey branch January 13, 2022 17:52
@svc-autorelease
Copy link
Collaborator

Released 4.58.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Jan 13, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.58.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | `DangerousIdentityKey` now allows `Class` to be used as a map or set key. | palantir/gradle-baseline#2036 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants