Add BugCheckerAutoService #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concrete BugChecker implementations should be annotated `@AutoService(BugChecker.class)` for auto registration with error-prone.
Generate changelog in
|
carterkozak
reviewed
Jan 7, 2022
| summary = "Concrete BugChecker implementations should be annotated " | ||
| + "`@AutoService(BugChecker.class)` for auto registration with error-prone.", | ||
| severity = SeverityLevel.ERROR, | ||
| tags = StandardTags.PERFORMANCE) |
There was a problem hiding this comment.
I don’t think this is a perf issue :-)
There was a problem hiding this comment.
doh, copy pasted that block
carterkozak
approved these changes
Jan 7, 2022
|
Released 4.56.0 |
This was referenced Jan 8, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 8, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.56.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Add BugCheckerAutoService<br><br>Concrete BugChecker implementations should be annotated<br>`@AutoService(BugChecker.class)` for auto registration with error-prone. | palantir/gradle-baseline#2028 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 8, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
If a BugChecker is not annotated as
@AutoService(BugChecker.class)it will not be registered with error-prone as an available bug pattern (see #2024 & #2026).After this PR
==COMMIT_MSG==
Add BugCheckerAutoService
Concrete BugChecker implementations should be annotated
@AutoService(BugChecker.class)for auto registration with error-prone.==COMMIT_MSG==
Possible downsides?