Improve coordination between java-versions and idea ipr #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
👍 |
|
Awesome thanks @carterkozak |
|
Released 4.50.0 |
This was referenced Dec 8, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Dec 8, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.47.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection | palantir/gradle-baseline#2009 | ## 4.48.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Disable errorprone in intellij | palantir/gradle-baseline#2010 | ## 4.49.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Allow projects to override library auto-detection | palantir/gradle-baseline#2011 | ## 4.50.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Improve coordination between java-versions and idea ipr allowing project iprs to be successfully imported | palantir/gradle-baseline#2012 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 8, 2021
tpetracca
reviewed
Dec 8, 2021
| import org.gradle.plugins.ide.idea.model.IdeaLanguageLevel | ||
| import org.gradle.plugins.ide.idea.model.IdeaModule | ||
| import org.gradle.plugins.ide.idea.model.Jdk | ||
|
|
There was a problem hiding this comment.
what happened with the imports here?
There was a problem hiding this comment.
We don't have a formatter for groovy that automatically cleans up imports.
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
ipr imports failed to build due to skewed bytecode versions, requiring manual edits to ipr files and UI costomization.
After this PR
"it just works"
==COMMIT_MSG==
Improve coordination between java-versions and idea ipr allowing project iprs to be successfully imported
==COMMIT_MSG==
Possible downsides?
I don't actually know groovy, and write java with a different extension. I suspect there's some clever syntax that makes this easier ¯_(ツ)_/¯