Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions plugin requires gradle 7 #1965

Merged
merged 2 commits into from
Nov 8, 2021
Merged

versions plugin requires gradle 7 #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8362e0
versions plugin requires gradle 7
carterkozak Nov 8, 2021
d7081b9
Add generated changelog entries
svc-changelog Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/@unreleased/pr-1965.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type: fix
fix:
description: The `com.palantir.baseline-java-versions` plugin requires gradle 7
and fails eagerly on older versions. Previously it would cause non-obvious failures
later depending on task execution.
links:
- https://github.com/palantir/gradle-baseline/pull/1965
8 changes: 8 additions & 0 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineJavaVersions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,24 @@
import org.gradle.api.publish.PublishingExtension;
import org.gradle.api.publish.ivy.IvyPublication;
import org.gradle.api.publish.maven.MavenPublication;
import org.gradle.util.GradleVersion;

public final class BaselineJavaVersions implements Plugin<Project> {

public static final String EXTENSION_NAME = "javaVersions";

public static final GradleVersion MIN_GRADLE_VERSION = GradleVersion.version("7.0");

@Override
public void apply(Project project) {
if (!Objects.equals(project, project.getRootProject())) {
throw new GradleException("BaselineJavaVersions may only be applied to the root project");
}
GradleVersion currentGradleVersion = GradleVersion.current();
if (currentGradleVersion.compareTo(MIN_GRADLE_VERSION) < 0) {
throw new GradleException(String.format(
"BaselineJavaVersions requires %s. %s is not supported", MIN_GRADLE_VERSION, currentGradleVersion));
}
BaselineJavaVersionsExtension rootExtension =
project.getExtensions().create(EXTENSION_NAME, BaselineJavaVersionsExtension.class, project);
project.allprojects(proj -> proj.getPluginManager().withPlugin("java", unused -> {
Expand Down