Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" #1957

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de7053
Revert "Feature: Zero Warmup Guava RateLimiter (#1950)"
carterkozak Nov 4, 2021
2f1ab4b
Add generated changelog entries
svc-changelog Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ Safe Logging can be found at [github.com/palantir/safe-logging](https://github.c
- `PreferImmutableStreamExCollections`: It's common to use toMap/toSet/toList() as the terminal operation on a stream, but would be extremely surprising to rely on the mutability of these collections. Prefer `toImmutableMap`, `toImmutableSet` and `toImmutableList`. (If the performance overhead of a stream is already acceptable, then the `UnmodifiableFoo` wrapper is likely tolerable).
- `DangerousIdentityKey`: Key type does not override equals() and hashCode, so comparisons will be done on reference equality only.
- `ConsistentOverrides`: Ensure values are bound to the correct variables when overriding methods
- `NoWarmupRateLimiter`: Ensures Guava RateLimiter initializers specify a warm-up duration.

### Programmatic Application

Expand Down
72 changes: 0 additions & 72 deletions baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/NoWarmupRateLimiter.java
View file
Open in desktop

This file was deleted.

113 changes: 0 additions & 113 deletions ...e-error-prone/src/test/java/com/palantir/baseline/errorprone/NoWarmupRateLimiterTest.java
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions changelog/@unreleased/pr-1957.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: fix
fix:
description: 'Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" which results
in no rate limiting'
links:
- https://github.com/palantir/gradle-baseline/pull/1957
1 change: 0 additions & 1 deletion ...ne-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class BaselineErrorProneExtension {
"LambdaMethodReference",
"LoggerEnclosingClass",
"LogsafeArgName",
"NoWarmupRateLimiter",
"ObjectsHashCodeUnnecessaryVarargs",
"OptionalFlatMapOfNullable",
"OptionalOrElseMethodInvocation",
Expand Down