Feature: Zero Warmup Guava RateLimiter #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/gradle-baseline into keviny/zero-warm-up-rate-limiter
carterkozak
reviewed
Nov 2, 2021
Co-authored-by: Carter Kozak <ckozak@ckozak.net>
carterkozak
reviewed
Nov 2, 2021
...line-error-prone/src/test/java/com/palantir/baseline/errorprone/NoWarmupRateLimiterTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 2, 2021
...line-error-prone/src/test/java/com/palantir/baseline/errorprone/NoWarmupRateLimiterTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 2, 2021
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/NoWarmupRateLimiter.java
Show resolved
Hide resolved
carterkozak
approved these changes
Nov 2, 2021
|
Released 4.32.0 |
This was referenced Nov 2, 2021
This was referenced Nov 2, 2021
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Nov 2, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.32.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | Zero Warmup Guava RateLimiter | palantir/gradle-baseline#1950 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Nov 2, 2021
|
This PR introduced a behavior change. After this change, we have unit tests that began failing. I don't think it's reasonable to assume that everyone wants this behavior. |
Right, it requires human intervention to merge. Many consumers do want this behavior, the idea is that a duration should always be provided to explicitly acknowledge the behavior either way. We suggest the value we think most folks want. |
|
I think there's something else going on here. For example, this test will pass: @ParameterizedTest
@ValueSource(ints = {1, 10, 100, 1000})
void testRateLimiter(int permitsPerSecond) {
RateLimiter rateLimiterZero = RateLimiter.create(permitsPerSecond, Duration.ZERO);
assertThat(Stream.generate(rateLimiterZero::tryAcquire)
.limit(10 * permitsPerSecond)
.allMatch(v -> v))
.isTrue();
} |
|
Ouch, good catch. |
carterkozak
added a commit
that referenced
this pull request
Nov 4, 2021
This reverts commit 3219b6c. Warmup of zero results in no rate limiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
This addresses #1946
After this PR
==COMMIT_MSG==
Adds a new rule NoWarmupRateLimiter that catches
RateLimite.createcalls with no explicit warmup arguments.==COMMIT_MSG==
Possible downsides?