Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow trailing comma in annotation arrays #1904

Merged
merged 2 commits into from
Sep 3, 2021
Merged

allow trailing comma in annotation arrays #1904

merged 2 commits into from
Sep 3, 2021

Conversation

rzpt
Copy link
Contributor

@rzpt rzpt commented Sep 2, 2021

Before this PR

@JsonIgnoreProperties({
         "foo",
         "bar", // This comma is not allowed
})

It's better to allow it to minimize diffs.

After this PR

==COMMIT_MSG==
allow trailing comma in annotation arrays
==COMMIT_MSG==

Possible downsides?

None.

@changelog-app
Copy link

changelog-app bot commented Sep 2, 2021 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

allow trailing comma in annotation arrays

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from xRuiAlves September 2, 2021 02:37
@carterkozak
Copy link
Contributor

I think this is reasonable, it would certainly make diffs in excavator-gradle cleaner (roomba-lint additions come to mind). I'm going to give folks on the team an hour or two to opine before I merge.

carterkozak
carterkozak approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed, all in favor.

@bulldozer-bot bulldozer-bot bot merged commit 139e0dd into develop Sep 3, 2021
@bulldozer-bot bulldozer-bot bot deleted the allow-trailing-comma branch September 3, 2021 14:40
@svc-autorelease
Copy link
Collaborator

Released 4.23.0

This was referenced Sep 3, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Sep 3, 2021
@svc-excavator-bot
Excavator: Upgrades Baseline to the latest version (#334)
cab760d 
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.23.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | allow trailing comma in annotation arrays | palantir/gradle-baseline#1904 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 3, 2021
Merged
Merged
Merged
This was referenced Sep 3, 2021
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@xRuiAlves xRuiAlves Awaiting requested review from xRuiAlves

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rzpt @carterkozak @svc-autorelease @svc-changelog