Implement LoggerInterpolationConsumesThrowable #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag as an ERROR when logging statements fail to produce a stack trace due to excessive slf4j-style interpolation placeholders.
Generate changelog in
|
carterkozak
commented
Aug 18, 2021
| return Description.NO_MATCH; | ||
| } | ||
| int extraPlaceholders = stringPlaceholders - nonThrowableParameters; | ||
| return buildDescription(tree) |
There was a problem hiding this comment.
There are a few common patterns we could likely auto-fix, but enough cases we can't that I haven't attempted to implement one.
If we find a lot of failures ending with {} or : {} it may be reasonable to automatically update them.
There was a problem hiding this comment.
Might be interesting to track how many excavators fail to upgrade with this check, given we can't autofix them
|
Released 4.21.0 |
This was referenced Aug 19, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Aug 19, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.21.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | error-prone LoggerInterpolationConsumesThrowable: Flag as an ERROR when logging statements fail to produce a stack trace due to excessive slf4j-style interpolation placeholders. | palantir/gradle-baseline#1886 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Aug 19, 2021
This was referenced Aug 19, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag as an ERROR when logging statements fail to produce a
stack trace due to excessive slf4j-style interpolation
placeholders.
==COMMIT_MSG==
error-prone LoggerInterpolationConsumesThrowable: Flag as an ERROR when logging statements fail to produce a stack trace due to excessive slf4j-style interpolation placeholders.
==COMMIT_MSG==