-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing setProperty error when using Gradle 6 #1884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
approved these changes
Aug 18, 2021
|
Released 4.20.0 |
This was referenced Aug 18, 2021
Merged
This was referenced Aug 18, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
With #1875, baseline is build using Gradle 7 and transitively Groovy 3.x.
As a result, projects that still use Gradle 6 and thus Groovy 2.x fail with the following error when applying the
BaselinEclipse
orBaselineIdea
plugin (both are the only plugins that are still Groovy and not Java classes) (example):Haven't gotten completely on the bottom of this but the issue seems to be that going from Groovy 2.x to 3.x
GroovyObjectSupport
is no longer provided per default.Relevant issue: https://issues.apache.org/jira/browse/GROOVY-4855
After this PR
Adding
extends GroovyObjectSupport
adds default implementations of Groovy methods includingsetProperty
.Tested it on two internal repos and compiled again.
==COMMIT_MSG==
Fix missing setProperty error when using Gradle 6
==COMMIT_MSG==