Enforce PreferSafeLogger at WARNING level
#1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the PreferSafeLogger check in a couple small ways: 1. The check no longer applies to test code (enforcement as well as refactoring) 2. The check will fail on code that it cannot convert. We want to migrate away from slf4j to the safe-logging facade, this is necessary to prevent leakage.
Generate changelog in
|
fawind
approved these changes
Aug 16, 2021
This was referenced Aug 16, 2021
Merged
This was referenced Aug 16, 2021
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Aug 17, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.14.0 _Automated release, no documented user facing changes_ ## 4.15.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Automatically fix upstream `LoopOverCharArray` | palantir/gradle-baseline#1873 | ## 4.16.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | JavaDoc uses UTF-8 encoding by default | palantir/gradle-baseline#1879 | ## 4.17.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Enforce `PreferSafeLogger` at `WARNING` level matching `Slf4jLogsafeArgs` and `PreferSafeLoggingPreconditions`. This doesn't apply to gradle plugins. | palantir/gradle-baseline#1876 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PreferSafeLogger check in a couple small ways:
well as refactoring)
to migrate away from slf4j to the safe-logging facade, this
is necessary to prevent leakage.
After this PR
==COMMIT_MSG==
Enforce
PreferSafeLoggeratWARNINGlevel matchingSlf4jLogsafeArgsandPreferSafeLoggingPreconditions. This doesn't apply to gradle plugins.==COMMIT_MSG==