PreferSafeLogger produces suggestions which compile with >10 args #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
approved these changes
Aug 11, 2021
|
Released 4.11.0 |
This was referenced Aug 11, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Aug 11, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.11.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | PreferSafeLogger produces suggestions which compile with >10 args | palantir/gradle-baseline#1866 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Aug 11, 2021
This was referenced Aug 11, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Some suggestions didn't compile.
After this PR
Originally I planned to opt out of updating calls with >10 args, but it's not terribly difficult to make these work properly, just makes the code a little more complicated.
==COMMIT_MSG==
PreferSafeLogger produces suggestions which compile with >10 args
==COMMIT_MSG==
Possible downsides?
Slightly more complex.