Fix PreferSafeLogger edge case that produced non-compiling code #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases we wouldn't go this far to ensure green builds, these are easy enough to manually update. However, it's important that automation can roll out the new facade without blocking for devs to make changes, and we can follow-up with a strict check later on to migrate the rest.
Generate changelog in
|
carterkozak
commented
Jul 23, 2021
| "class Test {", | ||
| " private static final Logger log = LoggerFactory.getLogger(Test.class);", | ||
| " void action() {", | ||
| " log.info(\"foo\", SafeArg.of(\"name\", log.getName()));", |
There was a problem hiding this comment.
Previously the log.getName() method invocation hid in the shadow of the parent log.info node, so the recommended fix wouldn't compile.
tpetracca
approved these changes
Jul 23, 2021
|
Released 4.7.0 |
This was referenced Jul 23, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 24, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.7.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix PreferSafeLogger edge case that produced suggested fixes that didn't compile without human interaction. | palantir/gradle-baseline#1851 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 24, 2021
This was referenced Jul 24, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases we wouldn't go this far to ensure green builds, these
are easy enough to manually update. However, it's important that
automation can roll out the new facade without blocking for devs
to make changes, and we can follow-up with a strict check later
on to migrate the rest.
==COMMIT_MSG==
Fix PreferSafeLogger edge case that produced suggested fixes that didn't compile without human interaction.
==COMMIT_MSG==