Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress existing ProxyNonConstantType failures to ease rollout #1850

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

carterkozak
Copy link
Contributor

This check is primarily meant to prevent future badness, in most
cases existing uses cannot be easily removed.

After this PR

==COMMIT_MSG==
Suppress existing ProxyNonConstantType failures to ease rollout
==COMMIT_MSG==

Possible downsides?

Some low-hanging/unused cases may not be resolved.

This check is primarily meant to prevent future badness, in most
cases existing uses cannot be easily removed.
@carterkozak carterkozak requested a review from fawind July 23, 2021 16:15
@changelog-app
Copy link

changelog-app bot commented Jul 23, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Suppress existing ProxyNonConstantType failures to ease rollout

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 4c63ce9 into develop Jul 23, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/ProxyNonConstantType_suppressions branch July 23, 2021 16:19
@svc-autorelease
Copy link
Collaborator

Released 4.6.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Jul 23, 2021
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.5.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Implement automatic fixes for `ImmutablesStyle` | palantir/gradle-baseline#1846 |


## 4.6.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Suppress existing `ProxyNonConstantType` failures to ease rollout | palantir/gradle-baseline#1850 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants