Handle additional hashing cases #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlosna
approved these changes
Apr 16, 2021
| MAP_COLLECTOR, | ||
| CONCURRENT_MAP_COLLECTOR, | ||
| UNMODIFIABLE_MAP_COLLECTOR, | ||
| IMMUTABLE_MAP_COLLECTOR); |
There was a problem hiding this comment.
maybe overkill, but do we want to cover StreamEx toImmutableMap & toImmutableSet as well (PreferImmutableStreamExCollections pushes these when using StreamEx)?
There was a problem hiding this comment.
Let's punt those cases for now, I think they're less common than the stdlib/guava/cache cases, and I'm less familiar with StreamEx.
There was a problem hiding this comment.
Sounds good. We can also check the JDK 9+ Map.of & Set.of in a follow up .
|
@carterkozak defer to you on when you want to merge into the PR branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Handle additional hashing cases
==COMMIT_MSG==