Fix path sensitivity of compile tasks #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Released 3.57.1 |
schlosna
reviewed
Nov 26, 2020
| errorProneOptions | ||
| .getExcludedPaths() | ||
| .set(String.format( | ||
| "%s%s(build|src%sgenerated.*)%s.*", | ||
| Pattern.quote(projectPath), separator, separator, separator)); | ||
| ".*(build%sgenerated%ssources|src%sgenerated.*)%s.*", |
There was a problem hiding this comment.
This does not seem to handle cases that previously were excluded such as build/metricSchema/generated_src used by metric-schema which is causing the baseline bump excavator on tritium to fail compilation: https://app.circleci.com/pipelines/github/palantir/tritium/906/workflows/7c65b97b-b475-46fc-a1e1-b5a4bf7198a0/jobs/11565
Filed #1570
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Our build caching is currently kinda broken, because you can't get cache hits between local & CI. build scan link
Specifically, on a local run the java compiler would be invoked with the following argument, which contains an absolute path 🌶🌶🌶:
When the repo is the checked out to a different location (e.g.
/home/circleci/container-vuln-scanner), it computes a different set of args and causes a cache miss.cc @jmcampanini this is example number (3) of gradle enterprise saving the day
After this PR
==COMMIT_MSG==
JavaCompile tasks should now get more build cache hits irrespective of the location of your repo on disk, as
baseline-errorproneno longer injects an absolute path intoerrorproneOptions.excludedPaths.==COMMIT_MSG==
Interestingly I think that windows compilation was also broken, and that this might fix it.
Possible downsides?