-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugin: 'com.palantir.baseline-enable-preview-flag' #1549
Conversation
Generate changelog in
|
Looks good! Need to double check but do we also need to set the preview flag for the Edit: Tried it and we also need to set preview on javadoc. Something like: tasks.withType(Javadoc) {
options.addBooleanOption('-enable-preview', true)
options.addStringOption("source", SOURCE_COMPAT)
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc is just nasty. But looks good!
Released 3.52.0 |
Before this PR
I have a PR up internally on template-witchcraft#1414 which demonstrates how verbose it is to opt-in to feature previews, e.g. records. As described in this stackoverflow answer, I had to add:
Which was pretty lame. Additionally, you'd have to add this to every project.
After this PR
==COMMIT_MSG==
Add the new line
apply plugin: 'com.palantir.baseline-enable-preview-flag'
to your subprojects block to enable the usage of unreleased java features (e.g. records, switch expressions, var keyword etc).Note, this plugin is a no-op on any project where you have a low sourceCompatibility.
==COMMIT_MSG==
cc @robert3005 who usually likes shiny new things
Possible downsides?