Disable --release flag when --add-exports is used #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
changed the title
iamdanfox
approved these changes
Nov 12, 2020
|
Released 3.50.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
To bring the palantir-java-formatter to java14+ we need to export the now internal
com.sun.tools.javacapi using--add-exports. However, on newer jdks it is not allowed to use--add-exportsin combination with--release(ref).After this PR
Add a gradle property to disable thecom.palantir.baseline-release-compatibilityplugin when set. This is not intended to be used generally but only in the very few places where we need full control over the provided compiler args.Updated PR:
Don't set the
--releaseflag if--add-exportsflags are used.==COMMIT_MSG==
Disable --release flag when --add-exports is used
==COMMIT_MSG==
Possible downsides
It's a bit hidden so users might get confused if their --release flag disappears.