Implement DeprecatedGuavaObjects error-prone migration #1521
Conversation
Generate changelog in
|
| .named("equal"); | ||
| private static final Matcher<ExpressionTree> HASH_CODE_MATCHER = MethodMatchers.staticMethod() | ||
| .onClass("com.google.common.base.Objects") | ||
| .named("hashCode"); |
There was a problem hiding this comment.
should we treat single arg version differently to map to java.util.Objects.hashCode(Object) and varargs maps to java.util.Objects.hash(Objects...)?
There was a problem hiding this comment.
I was planning to keep this simple as a direct migration and write a separate check for java.util.Objects.hash(value) -> java.util.Objects.hashCode(value) to eventually resolve to the ideal implementation.
That would result in the first refactor run failing in this case, so it might be fine to share the complexity with this check as well. What do you think?
There was a problem hiding this comment.
👍 your proposal makes sense to me and is additive beyond just the Guava -> java.util conversion
==COMMIT_MSG==
Implement DeprecatedGuavaObjects error-prone migration
==COMMIT_MSG==