Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-prone UnnecessarilyQualified #1510

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

carterkozak
Copy link
Contributor

Before this PR

Mixed qualified and unqualified uses of the same type in the same java file.

After this PR

Note that we don't disallow fully qualified classes, they can be useful when two types with the same simple name are used to avoid ambiguity.

==COMMIT_MSG==
error-prone UnnecessarilyQualified
==COMMIT_MSG==

Possible downsides?

Might cause code churn, however it makes the code substantially easier to follow, and fixes itself.

@changelog-app
Copy link

changelog-app bot commented Oct 14, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

error-prone UnnecessarilyQualified

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak
Copy link
Contributor Author

Validated on a large internal project.

Copy link
Contributor

@ferozco ferozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ferozco
Copy link
Contributor

ferozco commented Oct 14, 2020

🤖

@bulldozer-bot bulldozer-bot bot merged commit 0bc748e into develop Oct 14, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/UnnecessarilyQualified branch October 14, 2020 22:20
@svc-autorelease
Copy link
Collaborator

Released 3.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants