Better error message on class uniqueness lock file failure #1452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Trying to diagnose a problem with an internal project where circle says that
checkClassUniqueness
but locallycheckClassUniqueness --write-locks
does nothing. Very hard to diagnose as it doesn't show the expected difference. Currently looks like:After this PR
==COMMIT_MSG==
When
checkClassUniqueness
fails, it will show the difference between the actual and expected lock file.==COMMIT_MSG==
This will make it easier to debug. Now looks like:
Possible downsides?
None I can think of.