validate against ambiguous references #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
changed the title
ferozco
reviewed
Jun 1, 2020
| if (classSymbol == null) { | ||
| return false; | ||
| } | ||
| Set<Symbol.MethodSymbol> matching = ASTHelpers.findMatchingMethods( |
There was a problem hiding this comment.
this is a super cool helper method! didn't know it existed
ferozco
reviewed
Jun 1, 2020
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class LambdaMethodReferenceTest { | ||
|
|
||
| private CompilationTestHelper compilationHelper; | ||
| private RefactoringValidator refactoringValidator; | ||
| private CompilationTestHelper compile() { |
There was a problem hiding this comment.
gotta keep those tests fast 😛
There was a problem hiding this comment.
heh, most of our tests are structured this way so I moved it over. I think I migrated most of them after hitting a few cases where tests flaked after helper/validator instances were reused (due to either parallelism or multiple asserts in a single test). This way they're always clean regardless of other state!
ferozco
approved these changes
Jun 1, 2020
|
There's one more bug that I'm aware of where we trasform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?