Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class uniqueness non-deterministic ordering #1283

Merged

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Mar 3, 2020

Before this PR

There isn't a deterministic ordering on various parts of the baseline-class-uniqueness.lock file that's produced. This can cause failures as the generated file is different from the one on disk, despite having the same information.

After this PR

==COMMIT_MSG==
The checkClassUniqueness will no longer spuriously fail due to inconsistent ordering in the baseline-class-uniqueness.lock file.
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Mar 3, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The checkClassUniqueness task will no longer spuriously fail due to inconsistent ordering in the baseline-class-uniqueness.lock file.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from iamdanfox March 3, 2020 17:04
@CRogers CRogers requested review from dansanduleac and removed request for iamdanfox March 3, 2020 17:06
…b.com:palantir/gradle-baseline into callumr/fix-class-uniqueness-non-unique-order
Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bulldozer-bot bulldozer-bot bot merged commit ab4bfae into develop Mar 4, 2020
@bulldozer-bot bulldozer-bot bot deleted the callumr/fix-class-uniqueness-non-unique-order branch March 4, 2020 13:22
@svc-autorelease
Copy link
Collaborator

Released 3.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants