Fix class uniqueness non-deterministic ordering #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…b.com:palantir/gradle-baseline into callumr/fix-class-uniqueness-non-unique-order
dansanduleac
reviewed
Mar 3, 2020
...-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckClassUniquenessLockTask.java
Outdated
Show resolved
Hide resolved
dansanduleac
approved these changes
Mar 4, 2020
bulldozer-bot
bot
deleted the
callumr/fix-class-uniqueness-non-unique-order
branch
|
Released 3.7.5 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
There isn't a deterministic ordering on various parts of the
baseline-class-uniqueness.lockfile that's produced. This can cause failures as the generated file is different from the one on disk, despite having the same information.After this PR
==COMMIT_MSG==
The
checkClassUniquenesswill no longer spuriously fail due to inconsistent ordering in thebaseline-class-uniqueness.lockfile.==COMMIT_MSG==