Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline-exact-dependencies stops resolving compileOnly #1260

Merged
merged 6 commits into from
Feb 26, 2020

Conversation

dansanduleac
Copy link
Contributor

Before this PR

baseline-exact-dependencies was trying to resolve compileOnly and annotationProcessor in order to determine dependencies that should be ignored because they are "source-only".
This now breaks with 3.5.0 / #1254 because we've banned resolving compileOnly directly.

After this PR

==COMMIT_MSG==
Fix baseline-exact-dependencies to no longer resolve compileOnly directly.

Instead, we create another configuration extending from compileOnly, which we tell to resolve only compile variants (so they'll be guaranteed to be the same variants as what's resolved by compileClasspath).
Also, excluding annotationProcessor was bogus because annotationProcessor is entirely independent from the other java configurations and doesn't end up in compileClasspath at all.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Feb 26, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix baseline-exact-dependencies to no longer resolve compileOnly directly.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind February 26, 2020 13:13
@dansanduleac dansanduleac requested review from CRogers and removed request for fawind February 26, 2020 13:13
@bulldozer-bot bulldozer-bot bot merged commit d8be9cd into develop Feb 26, 2020
@bulldozer-bot bulldozer-bot bot deleted the ds/fix-exact-dependencies branch February 26, 2020 13:39
@svc-autorelease
Copy link
Collaborator

Released 3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants