Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off ParenPad when p-j-f enabled #1205

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

iamdanfox
Copy link
Contributor

Before this PR

Enabling palantir-java-format on an internal repo triggered ParenPad on the following code snippet:

        wc.filter(
                new ExcludeServletPathFilter( // Ignore cookie auth check for /api
                        new CookieAuthServletFilter(
                                wc.conjureClients()
                                        .client(RetrofitOAuth2Client.class, MULTIPASS)
                                        .get(),

it turns out it really wanted:

                new ExcludeServletPathFilter(// Ignore cookie auth check for /api

I think this ParenPad check is asking for something silly here, and given that users can't bring back the old behaviour anyway, I think it's net negative.

After this PR

==COMMIT_MSG==
Checkstyle's ParenPad rule is turned off when using palantir-java-format, to avoid disagreements that can't be fixed by the user.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Feb 3, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Checkstyle's ParenPad rule is turned off when using palantir-java-format, to avoid disagreements that can't be fixed by the user.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco February 3, 2020 13:45
@iamdanfox iamdanfox requested review from dansanduleac and removed request for ferozco February 3, 2020 13:46
@bulldozer-bot bulldozer-bot bot merged commit d2b87b2 into develop Feb 3, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/formatter-subsumes-checkstyle branch February 3, 2020 14:39
@svc-autorelease
Copy link
Collaborator

Released 3.2.1

This was referenced Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants