Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorProneApply removes suppressed UnusedVariable field #1159

Closed
dansanduleac opened this issue Jan 10, 2020 · 3 comments
Closed

errorProneApply removes suppressed UnusedVariable field #1159

dansanduleac opened this issue Jan 10, 2020 · 3 comments
Labels

Comments

@dansanduleac
Copy link
Contributor

What happened?

running classes -PerrorProneApply in conjure-python removed this "unused" field which is actually necessary for argument parsing to work as expected.

        @CommandLine.Unmatched
        @SuppressWarnings("UnusedVariable")
        private List<String> unmatchedOptions;

What did you want to happen?

Don't remove fields that are explicitly marked with @SuppressWarnings("UnusedVariable")

@carterkozak
Copy link
Contributor

i think we should take one more step, and avoid removing fields that are annotated.

@dansanduleac
Copy link
Contributor Author

Like altogether? That might make sense. Is there any way we can make it a suggestion instead for those cases?

@carterkozak
Copy link
Contributor

carterkozak commented Jan 10, 2020

I'm not aware of any way to change the level of a check dynamically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants