Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to go mod #35

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Convert to go mod #35

merged 2 commits into from
Apr 9, 2020

Conversation

ajlake
Copy link
Contributor

@ajlake ajlake commented Apr 9, 2020 •
edited
Loading

Fixes #9

bluekeyes
bluekeyes approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little unsure about all of the downstream consequences of this, but modules are the future, so let's try it out.

@ajlake
Copy link
Contributor Author

ajlake commented Apr 9, 2020

:shipit: 🍿

@ajlake ajlake merged commit 2bb8a4a into develop Apr 9, 2020
@ajlake ajlake deleted the ajlake/mod branch April 9, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluekeyes bluekeyes bluekeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add go.mod and bump go-github dependency
2 participants
@ajlake @bluekeyes