-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service loader for jdk21 #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Jan 8, 2024
...ule-core-jdk21/src/main/resources/META-INF/services/java.net.spi.InetAddressResolverProvider
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Jan 8, 2024
carterkozak
approved these changes
Jan 8, 2024
Released 1.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Previous attempt at adding support for jdk21 didn't work, because the service loader config wasn't correct.
After this PR
Fixes jdk21 support, and now uses integration tests rather than unit tests for the project so we actually test jdk21 functionality appropriately.
==COMMIT_MSG==
Jdk21 support (round 2)
==COMMIT_MSG==
Possible downsides?