Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verification-client server implementation #58

Merged
merged 45 commits into from
Oct 27, 2018
Merged

verification-client server implementation #58

merged 45 commits into from
Oct 27, 2018

Conversation

dansanduleac
Copy link
Contributor

@dansanduleac dansanduleac commented Oct 25, 2018 •
edited
Loading

  • Create verification-client: a rust server that implements VerificationClientService
  • Add tests against a mock server-under-test to verify its behaviour

@dansanduleac dansanduleac requested a review from a team as a code owner October 25, 2018 14:16
dansanduleac and others added 27 commits October 25, 2018 15:17
@dansanduleac
authors
c898c9d
nearly did something
614b339
@dansanduleac
add zipkin
f8c6b4d
@dansanduleac
Client errors namespace => ConjureVerificationClient
5766553
@dansanduleac
Make errors client-specific
e4a2fc4
@dansanduleac
Implement handle_auto_deserialise_test
b602b45
@dansanduleac
deserialize!
468ee8c
@dansanduleac
omg format
fdbe523
@dansanduleac
format
8ade81b
@dansanduleac
unused
f8c0a96
@dansanduleac
more unused
8cfd28f
@dansanduleac
Fmt remove more stuff
a72186b
@dansanduleac
more final touches
2e4824a
@dansanduleac
more unused
e01993e
@dansanduleac
log
62be5cf
@dansanduleac
change namespace for default errors
780027e
@dansanduleac
expose connection error to user
1e74c6c
@dansanduleac
format
c5b2dbe
@dansanduleac
fix templating!!!
cdb8d30
@dansanduleac
better error when url parse failure and max_num_retries(0)
732905f
@dansanduleac
USER_AGENT -> static
297911e
@dansanduleac
accept only JSON, we're not testing other wire formats
205adba
@dansanduleac
Handle null -> 204 response
6dba4a1
@dansanduleac
all empty conjure values -> accept 204
a8b4e93
@dansanduleac
assert content type matches expected types
b1c4ecd
@dansanduleac
cargo fmt
e5e9ac8
@dansanduleac
remove test macro_use
492ce61
ferozco
ferozco reviewed Oct 26, 2018
View reviewed changes
verification-client/src/resource.rs Outdated
);
match test_case {
Left(positive) => {
let test_body_str = positive.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor

ferozco
ferozco reviewed Oct 26, 2018
View reviewed changes
verification-client/src/resource.rs Outdated
}

Right(negative) => {
let response = builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify error code

@dansanduleac dansanduleac changed the title verification-client server implementation & reading test cases verification-client server implementation Oct 27, 2018
@dansanduleac dansanduleac merged commit 059908f into develop Oct 27, 2018
@dansanduleac dansanduleac deleted the fods/client-3 branch October 27, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozco ferozco ferozco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dansanduleac @ferozco