Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excavator: Upgrades Baseline to the latest version #638

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Excavator: Upgrades Baseline to the latest version #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ buildscript {
classpath 'com.netflix.nebula:gradle-info-plugin:5.2.0'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
classpath 'com.netflix.nebula:nebula-publishing-plugin:14.1.1'
classpath 'com.palantir.baseline:gradle-baseline-java:2.29.0'
classpath 'com.palantir.baseline:gradle-baseline-java:2.30.0'
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:1.12.4'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.2'
classpath 'gradle.plugin.org.inferred:gradle-processors:3.1.0'
Expand Down
5 changes: 2 additions & 3 deletions conjure-java-core/src/test/java/com/palantir/conjure/java/JerseyServiceEteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void jaxrs_client_can_make_a_call_to_an_empty_path() throws Exception {
clientUserAgent(),
new HostMetricsRegistry(),
clientConfiguration());
assertThat(emptyPathClient.emptyPath()).isEqualTo(true);
assertThat(emptyPathClient.emptyPath()).isTrue();
}

@Disabled("string returns in Jersey should use a mandated wrapper alias type")
Expand All @@ -117,8 +117,7 @@ public void client_can_retrieve_a_double_from_a_server() throws Exception {

@Test
public void client_can_retrieve_a_boolean_from_a_server() throws Exception {
assertThat(client.boolean_(AuthHeader.valueOf("authHeader")))
.isEqualTo(true);
assertThat(client.boolean_(AuthHeader.valueOf("authHeader"))).isTrue();
}

@Test
Expand Down
5 changes: 2 additions & 3 deletions conjure-java-core/src/test/java/com/palantir/conjure/java/UndertowServiceEteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void jaxrs_client_can_make_a_call_to_an_empty_path() throws Exception {
clientUserAgent(),
new HostMetricsRegistry(),
clientConfiguration());
assertThat(emptyPathClient.emptyPath()).isEqualTo(true);
assertThat(emptyPathClient.emptyPath()).isTrue();
}

@Test
Expand All @@ -171,8 +171,7 @@ public void client_can_retrieve_a_double_from_a_server() throws Exception {

@Test
public void client_can_retrieve_a_boolean_from_a_server() throws Exception {
assertThat(client.boolean_(AuthHeader.valueOf("authHeader")))
.isEqualTo(true);
assertThat(client.boolean_(AuthHeader.valueOf("authHeader"))).isTrue();
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...re-java-core/src/test/java/com/palantir/conjure/java/types/BeanSerdeIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void testSafeLongExampleSerde_tooLarge() {
public void testIgnoreProperties() throws Exception {
// Important for ensuring additive changes don't affect clients adversely
BooleanExample boolExample = mapper.readValue("{\"coin\": true, \"ignored\": \"field\"}", BooleanExample.class);
assertThat(boolExample.getCoin()).isEqualTo(true);
assertThat(boolExample.getCoin()).isTrue();
}

@Test
Expand Down