Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #557

Merged
merged 12 commits into from
Oct 14, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.4.0

Type Description Link
Improvement A new StrictUnusedVariable check will catch any unused arguments (e.g. AuthHeaders) to public methods. error-prone's built-in UnusedVariable would only apply to private methods or local fields. palantir/gradle-baseline#819
Improvement Message format checks use instanceof rather than catching palantir/gradle-baseline#821

To enable or disable this check, please contact the maintainers of Excavator.

@robert3005
Copy link
Contributor

It's weird that it didn't extract the java compile failures to test summary. Something must be off with our regexes

@robert3005 robert3005 closed this Sep 13, 2019
@robert3005 robert3005 reopened this Sep 13, 2019
@stale
Copy link

stale bot commented Sep 27, 2019

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Sep 27, 2019
@stale stale bot removed the stale label Sep 27, 2019
@stale
Copy link

stale bot commented Oct 11, 2019

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 11, 2019
@stale stale bot removed the stale label Oct 14, 2019
@@ -43,6 +43,7 @@ dependencies {
testCompile sourceSets.generatedJersey.output
testCompile sourceSets.generatedUndertow.output
testImplementation 'org.junit.jupiter:junit-jupiter'
testRuntimeOnly 'org.junit.vintage:junit-vintage-engine'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ferozco 🌶🌶🌶🌶

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

@bulldozer-bot bulldozer-bot bot merged commit 996b4bb into develop Oct 14, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch October 14, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants