-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating an HTTPS proxy #2903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
May 13, 2024
client-config/src/main/java/com/palantir/conjure/java/client/config/HttpsProxy.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
May 13, 2024
client-config/src/main/java/com/palantir/conjure/java/client/config/HttpsProxies.java
Outdated
Show resolved
Hide resolved
carterkozak
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Eric-Alvarez
force-pushed
the
ea/https-proxy
branch
from
May 13, 2024 16:53
da6f0e6
to
dcbecfa
Compare
policy-bot
bot
dismissed
carterkozak’s stale review
May 13, 2024 16:53
Invalidated by push of dcbecfa
carterkozak
approved these changes
May 13, 2024
Released 8.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to palantir/dialogue#2278
Before this PR
No support for new ProxyType HTTPS
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
A special Proxy instance will be created when the proxy type is HTTPS. Consumers need to check for this type to determine if the proxy should be connected to with HTTPS
Possible downsides?