SslSocketFactories avoids duplicate effort creating TLS components #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concretely, this simplifies creation of TrustContext and creating ClientConfiguration from a ServiceConfiguration to load the TrustManagerFactory from disk a single time rather than once for the X509TrustManager and a second time for the SSLContext to create an SSLSocketFactory. Additionally, we provide public utility functionality such that consumers may also avoid duplicating efforts with slight code changes, without reimplementing the logic to create SSLContext instances themselves.
Generate changelog in
|
mpritham
approved these changes
Apr 24, 2023
keystores/src/main/java/com/palantir/conjure/java/config/ssl/SslSocketFactories.java
Show resolved
Hide resolved
|
Released 7.54.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concretely, this simplifies creation of TrustContext and creating ClientConfiguration from a ServiceConfiguration to load the TrustManagerFactory from disk a single time rather than once for the X509TrustManager and a second time for the SSLContext to create an SSLSocketFactory.
Additionally, we provide public utility functionality such that consumers may also avoid duplicating efforts with slight code changes, without reimplementing the logic to create SSLContext instances themselves.
After this PR
==COMMIT_MSG==
SslSocketFactories avoids duplicate effort creating TLS components
==COMMIT_MSG==