Add public JsonFactory factories to ObjectMappers #2586
Conversation
Generate changelog in
|
| private static <F extends JsonFactory, B extends TSFBuilder<F, B>> B withDefaults(B builder) { | ||
| return builder | ||
| // Interning introduces excessive contention https://github.com/FasterXML/jackson-core/issues/946 | ||
| .disable(JsonFactory.Feature.INTERN_FIELD_NAMES); | ||
| } |
There was a problem hiding this comment.
Unclear if we want this to be public like withDefaultModules(ObjectMapper)/etc. I opted to keep it private to push consumers toward concrete factories where we can add instrumentation.
There was a problem hiding this comment.
Based on some other usages, making this public seems beneficial to consolidate functionality
There was a problem hiding this comment.
Let's revisit making this public later on since the string length metrics from our concrete factories are valuable to capture in the short term, and using withDefaults will bypass them.
| private static <F extends JsonFactory, B extends TSFBuilder<F, B>> B withDefaults(B builder) { | ||
| return builder | ||
| // Interning introduces excessive contention https://github.com/FasterXML/jackson-core/issues/946 | ||
| .disable(JsonFactory.Feature.INTERN_FIELD_NAMES); | ||
| } |
There was a problem hiding this comment.
Based on some other usages, making this public seems beneficial to consolidate functionality
|
Released 7.47.0 |
==COMMIT_MSG==
Add public JsonFactory factories to ObjectMappers
==COMMIT_MSG==