Fail if annotated server resource is used as a client #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
Apr 1, 2022
|
Released 7.33.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
FLUP on #2320 where we added the marker annotations.
After this PR
Fail if a JaxRs class is only annotated with
@JaxRsServerbut is used to create a client. Note that we still succeed if no annotation is given or if the class is annotated with both@JaxRsServerand@JaxRsClient.==COMMIT_MSG==
Fail if annotated server resource is used as a client
==COMMIT_MSG==
Possible downsides?
I wonder if this should be an error-prone check instead to fail at compile rather then runtime?
We might want to add something similar to verify client interfaces are not used as servers.