WebApplicationExceptionMapper treats redirection as informational #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
Mar 29, 2022
schlosna
commented
Mar 29, 2022
| log.error("Error handling request", SafeArg.of("errorInstanceId", errorInstanceId), exception); | ||
| } else { | ||
| log.info("Error handling request", SafeArg.of("errorInstanceId", errorInstanceId), exception); |
There was a problem hiding this comment.
I didn't change the behavior on the info logging here, but a case could be made we probably don't need the exception for non-5xx responses
|
Released 7.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
RedirectionExceptions were being logged at
ERROR, especially HTTP 304 Not ModifiedAfter this PR
==COMMIT_MSG==
WebApplicationExceptionMapper treats redirection as informational
==COMMIT_MSG==
Possible downsides?