Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Format Java files #1218

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Excavator: Format Java files #1218

merged 1 commit into from
Sep 24, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/format check.

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/format branch 2 times, most recently from d4d92f3 to 5a587e3 Compare September 16, 2019 17:25
@@ -84,15 +84,15 @@ private synchronized void pruneAndLog() {
private void logLeak(Optional<RuntimeException> stackTrace) {
if (stackTrace.isPresent()) {
log.warn("Resource leak detected - did you forget to close a resource properly? "
+ "This will likely hurt performance. Stack trace is of the call where "
+ "the acquire happened.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dansanduleac extra request- could we try and keep this old string wrapping indentation?? I think it makes it easier to differentiate this first arg (even though it spans multiple lines) from the second and third args.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could avoid modifying wrapped strings that aren't super incorrect, it would help some older codebases with longer wrapped templates. Take SQL for example:

// If this gets re-wrapped, it becomes more difficult to read
PreparedStatement preparedStatement = connection.prepareStatement(""
    + "SELECT Orders.OrderID, Customers.CustomerName, Shippers.ShipperName "
    + "FROM Orders "
    + "INNER JOIN Customers ON Orders.CustomerID = Customers.CustomerID "
    + "INNER JOIN Shippers ON Orders.ShipperID = Shippers.ShipperID "
    + "WHERE Orders.OrderID = ?");

Copy link
Contributor

@iamdanfox iamdanfox Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I think the eclipse formatter won't reflow any strings (even if they're >120 chars).

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/format branch 2 times, most recently from 4be8666 to 4527116 Compare September 19, 2019 00:36
@bulldozer-bot bulldozer-bot bot merged commit a64984e into develop Sep 24, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/format branch September 24, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants