Excavator: Format Java files #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/format
branch
2 times, most recently
from
1c4ca7d
to
eb82589
Compare
iamdanfox
reviewed
Sep 12, 2019
keystores/src/main/java/com/palantir/conjure/java/config/ssl/KeyStores.java
Outdated
Show resolved
Hide resolved
svc-excavator-bot
force-pushed
the
roomba/format
branch
2 times, most recently
from
d4d92f3
to
5a587e3
Compare
iamdanfox
reviewed
Sep 16, 2019
| @@ -84,15 +84,15 @@ private synchronized void pruneAndLog() { | |||
| private void logLeak(Optional<RuntimeException> stackTrace) { | |||
| if (stackTrace.isPresent()) { | |||
| log.warn("Resource leak detected - did you forget to close a resource properly? " | |||
| + "This will likely hurt performance. Stack trace is of the call where " | |||
| + "the acquire happened.", | |||
There was a problem hiding this comment.
@dansanduleac extra request- could we try and keep this old string wrapping indentation?? I think it makes it easier to differentiate this first arg (even though it spans multiple lines) from the second and third args.
There was a problem hiding this comment.
If we could avoid modifying wrapped strings that aren't super incorrect, it would help some older codebases with longer wrapped templates. Take SQL for example:
// If this gets re-wrapped, it becomes more difficult to read
PreparedStatement preparedStatement = connection.prepareStatement(""
+ "SELECT Orders.OrderID, Customers.CustomerName, Shippers.ShipperName "
+ "FROM Orders "
+ "INNER JOIN Customers ON Orders.CustomerID = Customers.CustomerID "
+ "INNER JOIN Shippers ON Orders.ShipperID = Shippers.ShipperID "
+ "WHERE Orders.OrderID = ?");There was a problem hiding this comment.
So far I think the eclipse formatter won't reflow any strings (even if they're >120 chars).
svc-excavator-bot
force-pushed
the
roomba/format
branch
2 times, most recently
from
4be8666
to
4527116
Compare
iamdanfox
approved these changes
Sep 23, 2019
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
4527116
to
b1cb150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/format check.
To enable or disable this check, please contact the maintainers of Excavator.