[v5] [popover2] fix(Popover2): restore basic support for some legacy class names #6228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fix a subtle bug in
{ Popover2 } from "@blueprintjs/popover2"
.Previously, this export was a simple alias for
{ Popover } from "@blueprintjs/core"
. When upgrading code bases to Blueprint v5, I found a some custom styles which reference CSS selectors such as:<Popover>
no longer renders those class names, which constitutes a break in the CSS API. We expect some breaks, but it's also possible to mitigate them by restoring some of the popover2 classes in<Popover2>
. We can't reasonably add back all of them, but we can cover the most used one: the target element class.