-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dist:css step to prod-ify CSS file #2241
Conversation
autoprefixer 7 for hoistingPreview: documentation | landing | table |
This would fix #2122 as well. ✨ (Edit: for those that don't already use autoprefixer, I mean.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! just small comments. I think the new script should be called css-dist
.browserslistrc
Outdated
@@ -0,0 +1,4 @@ | |||
# Browsers that we support | |||
|
|||
defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we be more explicit? I don't really want to have to look at the documentation for the default. also more comments in this file would be really helpful, to explain its context
@@ -0,0 +1,5 @@ | |||
#!/usr/bin/env bash | |||
|
|||
# Usage: sass-compile [outdir=lib/css/] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this more like css-dist
? it has nothing to do with sass.
yarn cache issue with renamed bin script causing build fails |
# ensure these are supported: | ||
Firefox ESR | ||
IE 11 | ||
# because no one likes a dead browser: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
that's annoying... let's merge into develop and fix things there if necessary |
Fixes #612, fixes #2122
Changes proposed in this pull request:
sass-compile
assert-package-layout
file-header
rule in tslint-configsass-dist
script runs postcss with autoprefixer and discard-comments plugins.browserslistrc
file instead of individual autoprefixer configReviewers should focus on: