Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IActionProps text accepts ReactNode #2088

Merged
merged 2 commits into from
Feb 6, 2018
Merged

IActionProps text accepts ReactNode #2088

merged 2 commits into from
Feb 6, 2018

Conversation

giladgray
Copy link
Contributor

Changes proposed in this pull request:

  • IActionProps text accepts React.ReactNode (instead of only strings)
    • affects Breadcrumb, Button, MenuItem, Toast
  • FileInput also accepts React.ReactNode text

@giladgray giladgray requested a review from adidahiya February 5, 2018 23:10
@blueprint-bot
Copy link

IActionProps text accepts ReactNode

Preview: documentation | landing | table

@blueprint-bot
Copy link

fix tests

Preview: documentation | landing | table

@adidahiya adidahiya merged commit 0428cb5 into develop Feb 6, 2018
@adidahiya adidahiya deleted the gg/text-node branch February 6, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @adidahiya