Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI build improvements #1939

Closed
wants to merge 3 commits into from
Closed

Circle CI build improvements #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb6e438
Apply Circle config.yml changes from cl/graduate-labs-to-core-2 branch
cmslewis Dec 18, 2017
88c3841
Add icons package
cmslewis Dec 18, 2017
af2769c
Add mocha dev dependency to packages/timezone
cmslewis Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,25 @@ jobs:
- checkout
- restore_cache:
keys:
- v5-dependency-cache-{{ checksum "yarn.lock" }}
- v5-dependency-cache-
- v6-dependency-cache-{{ checksum "yarn.lock" }}
- v6-dependency-cache-
- run: yarn
- run: echo "Checking if lockfiles changed..." && git diff --exit-code
- run: npm rebuild node-sass
- save_cache:
key: v5-dependency-cache-{{ checksum "yarn.lock" }}
key: v6-dependency-cache-{{ checksum "yarn.lock" }}
paths:
- ~/yarn
- ~/.cache/yarn
- node_modules
- packages/core/node_modules
- packages/datetime/node_modules
- packages/docs/node_modules
- packages/icons/node_modules
- packages/labs/node_modules
- packages/select/node_modules
- packages/table/node_modules
- packages/timezone/node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( I don't want to list out these package names again like this. let's move back to the old approach of persist_to_workspace with packages/*/node_modules/.bin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the singleRun edit fixes the other branch, I'm happy to just close this whole PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked.

- persist_to_workspace:
root: '.'
paths:
Expand All @@ -32,8 +40,8 @@ jobs:
at: '.'
- restore_cache:
keys:
- v5-dependency-cache-{{ checksum "yarn.lock" }}
- v5-dependency-cache-
- v6-dependency-cache-{{ checksum "yarn.lock" }}
- v6-dependency-cache-
- run: yarn compile
- persist_to_workspace:
root: '.'
Expand All @@ -50,8 +58,8 @@ jobs:
at: '.'
- restore_cache:
keys:
- v5-dependency-cache-{{ checksum "yarn.lock" }}
- v5-dependency-cache-
- v6-dependency-cache-{{ checksum "yarn.lock" }}
- v6-dependency-cache-
- run: yarn lint

dist-libs:
Expand All @@ -62,7 +70,7 @@ jobs:
- attach_workspace:
at: '.'
- restore_cache:
key: v5-dependency-cache-{{ checksum "yarn.lock" }}
key: v6-dependency-cache-{{ checksum "yarn.lock" }}
- run: yarn dist:libs
- persist_to_workspace:
root: '.'
Expand All @@ -83,7 +91,7 @@ jobs:
- attach_workspace:
at: '.'
- restore_cache:
key: v5-dependency-cache-{{ checksum "yarn.lock" }}
key: v6-dependency-cache-{{ checksum "yarn.lock" }}
- run: yarn dist:apps
- persist_to_workspace:
root: '.'
Expand All @@ -101,17 +109,17 @@ jobs:
- attach_workspace:
at: '.'
- restore_cache:
key: v5-dependency-cache-{{ checksum "yarn.lock" }}
key: v6-dependency-cache-{{ checksum "yarn.lock" }}
- run:
command: |
case $CIRCLE_NODE_INDEX in \
0) yarn lerna run test --scope '@blueprintjs/core' ;; \
1) yarn lerna run test --scope '@blueprintjs/datetime' ;; \
2) yarn lerna run test --scope '@blueprintjs/icons' ;; \
3) yarn lerna run test --scope '@blueprintjs/labs' ;; \
4) yarn lerna run test --scope '@blueprintjs/select' ;; \
5) yarn lerna run test --scope '@blueprintjs/table' ;; \
6) yarn lerna run test --scope '@blueprintjs/timezone' ;; \
0) cd packages/core && yarn test ;; \
1) cd packages/datetime && yarn test ;; \
2) cd packages/icons && yarn test ;; \
3) cd packages/labs && yarn test ;; \
4) cd packages/select && yarn test ;; \
5) cd packages/table && yarn test ;; \
6) cd packages/timezone && yarn test ;; \
esac

deploy-preview:
Expand Down
1 change: 1 addition & 0 deletions packages/timezone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"enzyme-adapter-react-16": "^1.1.0",
"es6-shim": "^0.35.3",
"karma": "^1.7.1",
"mocha": "^4.0.1",
"npm-run-all": "^4.1.1",
"react": "^16.2.0",
"react-dom": "^16.2.0",
Expand Down