React 16/Enzyme 3 - Fix datetime tests #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
requested review from
giladgray,
themadcreator,
adidahiya and
gscshoyru
gscshoyru
approved these changes
Dec 13, 2017
giladgray
reviewed
Dec 13, 2017
|
|
||
| getStartInput(root).simulate("focus"); | ||
| getStartInput(root).simulate("change", { target: { value: START_STR } }); | ||
| getStartInput(root).simulate("keydown", { which: Keys.ENTER }); |
There was a problem hiding this comment.
you might be able to chain these simulates and only get a new reference on line 426?
There was a problem hiding this comment.
Chatted IRL. Will leave it b/c we're not sure exactly if the input node would get stale between events.
|
Builds failing: test-select: test-core: @adidahiya @giladgray @gscshoyru - were these build failures happening before? |
|
Merging b/c the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the datetime tests that broke in the React 16 / Enzyme 3 upgrade.