Fix table tests #1897
Merged
Fix table tests #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
themadcreator
commented
Dec 12, 2017
themadcreator
commented
- Call super methods of AbstractComponent instead of validateProps directly
- Use new enzyme state method
- Use full mount instead of shallow mount
- Remove update tests due to awkward error boundary prop setting with new enzyme API (also already tested on mount)
- Call super methods of AbstractComponent instead of validateProps directly - Use new enzyme state method - Use full mount instead of shallow mount - Remove update tests due to awkward error boundary prop setting with new enzyme API (also already tested on mount)
adidahiya
approved these changes
Dec 12, 2017
gscshoyru
reviewed
Dec 12, 2017
packages/table/package.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "test": "npm-run-all -s compile:cjs test:pre -p test:karma test:iso", | |||
| "test:pre": "tsc -p ./test", | |||
| "test:karma": "karma start", | |||
| "test:karma:debug": "karma start --browsers=Chrome --single-run=false --reporters=mocha --debug", | |||
| "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug", | |||
There was a problem hiding this comment.
This probably shouldn't stay in, yes?
giladgray
reviewed
Dec 13, 2017
packages/table/test/tableTests.tsx
Outdated
|
|
||
| // selet the full table |
packages/table/test/tableTests.tsx
Outdated
| .find(`.${Classes.TABLE_ROW_HEADERS}`) | ||
| .find(`.${Classes.TABLE_HEADER}`) | ||
| .hostNodes() | ||
| .at(0); |
packages/table/test/tableTests.tsx
Outdated
| .at(0); | ||
| let rowHeader = table | ||
| .find(`.${Classes.TABLE_ROW_HEADERS}`) | ||
| .find(`.${Classes.TABLE_HEADER}`) |
There was a problem hiding this comment.
can combine these into a compound selector: .find(".one .two")
(few other places too)
adidahiya
approved these changes
Dec 13, 2017
giladgray
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.