Add option to KeyCombo component to hide key text

[tnrich]

It would be nice to have the option to not have the little text next to the special keys.

Aka there would no longer be "shift", just the icon.

[cmslewis]

Cool idea / makes sense. Would happily review a PR if you want to try tackling this, @tnrich!

[giladgray]

while i'm not opposed a feature that hides the name, i will say that we deliberately decided to always include the key name because the special symbols are not as widely known or used. omitting the name is a quick path to accessibility problems.

[tnrich]

@giladgray I think that makes sense most of the time but I was interested in a condensed version for use as context menu labels.

[giladgray]

@tnrich I think this component will be too visually heavy for menu item labels -- it's got a strong shadow so it looks like a keyboard key.

[tnrich]

@cmslewis I put in a PR above. @giladgray I am just updating the css in my app to make it look nice but I think it would be a cool use case to build this component into blueprint MenuItem component as a keyCombo prop or something.

[llorca]

Why not use the icon directly if you need it as a label within a context menu?

[tnrich]

I am using the KeyCombo component because it makes it a little easier to just put for example meta+c and have it look correct on windows and mac

…

On Tue, Jan 9, 2018, 7:59 PM Antoine Llorca ***@***.***> wrote: Why not use the icon directly if you need it as a label within a context menu? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1980 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACmqcZIf7Om-Qhd6rw2pQtJ9Ivj_Wcn2ks5tJCd5gaJpZM4RYBnn> .

[giladgray]

@tnrich yo i actually implemented this in #2256 without realizing there was an issue! <KeyCombo minimal> removes the <kbd> frames and the "Shift" text. see it in action in the new docs sidebar for button hotkeys.