-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excavator: Upgrades Baseline to the latest version #6470
Conversation
b1b4a2a
to
8768919
Compare
8768919
to
dd680dd
Compare
@@ -131,6 +131,7 @@ private InDbTimestampBoundStore( | |||
this.physicalBoundStoreStrategy = physicalBoundStoreStrategy; | |||
} | |||
|
|||
@SuppressWarnings("GuardedBy") // TODO (jkong): synchronize? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems odd and scary to suppress. I think we want something like the following instead:
private volatile DBType dbType;
private DBType getDbType(Connection connection) {
DBType type = this.dbType; // volatile read
if (type == null) {
synchronized (this) {
type = this.dbType;
if (type == null) {
type = ConnectionDbTypes.getDbType(connection);
this.dbType = type;
}
}
}
return type;
}
@@ -164,7 +164,8 @@ public boolean unlockAndFreeze(HeldLocksToken token) { | |||
} | |||
|
|||
@Override | |||
@SuppressWarnings("checkstyle:NoFinalizer") // TODO (jkong): Can we safely remove this without breaking things? | |||
@SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"}) // TODO (jkong): Can we safely remove this without | |||
// breaking things? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should migrate any finalize()
to JDK Cleaner
APIs as finalizer is deprecated in JDK 18 per JEP 421 and will be removed in the future. See also https://bugs.openjdk.org/browse/JDK-8253568
#6710 builds off this branch to fix up the build and clean up error-prone checks |
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
4.189.0
4.190.0
DangerousCollapseKeysUsage
error prone check to disallow usage ofcollapseKeys()
API ofEntryStream
.4.191.0
4.192.0
Automated release, no documented user facing changes
5.0.0
To enable or disable this check, please contact the maintainers of Excavator.