Excavator: Upgrades Baseline to the latest version #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
2 times, most recently
from
b1b4a2a
to
8768919
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
8768919
to
dd680dd
Compare
mdaudali
approved these changes
Mar 23, 2023
schlosna
reviewed
Aug 15, 2023
| @@ -131,6 +131,7 @@ private InDbTimestampBoundStore( | |||
| this.physicalBoundStoreStrategy = physicalBoundStoreStrategy; | |||
| } | |||
|
|
|||
| @SuppressWarnings("GuardedBy") // TODO (jkong): synchronize? | |||
There was a problem hiding this comment.
This seems odd and scary to suppress. I think we want something like the following instead:
private volatile DBType dbType;
private DBType getDbType(Connection connection) {
DBType type = this.dbType; // volatile read
if (type == null) {
synchronized (this) {
type = this.dbType;
if (type == null) {
type = ConnectionDbTypes.getDbType(connection);
this.dbType = type;
}
}
}
return type;
}
| @@ -164,7 +164,8 @@ public boolean unlockAndFreeze(HeldLocksToken token) { | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("checkstyle:NoFinalizer") // TODO (jkong): Can we safely remove this without breaking things? | |||
| @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"}) // TODO (jkong): Can we safely remove this without | |||
| // breaking things? | |||
There was a problem hiding this comment.
We should migrate any finalize() to JDK Cleaner APIs as finalizer is deprecated in JDK 18 per JEP 421 and will be removed in the future. See also https://bugs.openjdk.org/browse/JDK-8253568
|
#6710 builds off this branch to fix up the build and clean up error-prone checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
4.189.0
4.190.0
DangerousCollapseKeysUsageerror prone check to disallow usage ofcollapseKeys()API ofEntryStream.4.191.0
4.192.0
Automated release, no documented user facing changes
5.0.0
To enable or disable this check, please contact the maintainers of Excavator.