Support Psych 4.x gem #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.1 comes with Psych 4, which has a major breaking change The new YAML loading methods (Psych 4) do not load aliases unless they get the aliases: true argument. The old YAML loading methods (Psych 3) do not support the aliases keyword.
AdamBukowczyk
requested review from
wojtowicz
and removed request for
wojtowicz
wojtowicz
reviewed
Oct 16, 2024
| @@ -14,7 +14,7 @@ class Engine < Rails::Engine | |||
|
|
|||
| private | |||
| def apply_yaml_config(yaml) | |||
| cfg = (YAML.load(ERB.new(yaml).result)||{}).fetch(Rails.env, {}) | |||
| cfg = (YAML.load(ERB.new(yaml).result, aliases: true)||{}).fetch(Rails.env, {}) | |||
There was a problem hiding this comment.
Ok so according to description this aliases: true is something new in ruby 3.1 correct? Then this changes requires ruby version > 3.1?
So looks like we have to add this dependency to our gemspec similar like we have in other gems (example)
in our case
s.required_ruby_version = '>= 3.1.0'There was a problem hiding this comment.
Looks like this gem is only used in CAS application so this is good. Just please double check and confirm :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.1 comes with Psych 4, which has a major breaking change
The new YAML loading methods (Psych 4) do not load aliases unless they get the
aliases: trueargument.The old YAML loading methods (Psych 3) do not support the aliases keyword.
Related PR: