Non transient value type error #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong reference after rename Remove unnecessary method
# Conflicts: # src/Jab.FunctionalTests.Common/ContainerTests.cs
pakrym
reviewed
Dec 23, 2023
pakrym
reviewed
Dec 23, 2023
src/Jab/ContainerGenerator.cs
Outdated
| valueCallback(codeWriter, w => w.Append($"{cacheLocation}")); | ||
| if (serviceCallSite.ImplementationType.IsValueType) | ||
| { | ||
| valueCallback(codeWriter, w => w.Append($"{cacheLocation}!.Value")); |
There was a problem hiding this comment.
Is ! required? There is an if ... == null check right above.
There was a problem hiding this comment.
Technically, but not really, it's a == default check which still causes the compiler to throw an error, I can change it to == null and remove the !
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you register a value type as singleton or scoped you get a compile error.
The compile error happens because there's a nullable field saved for each registration, which in reference type is implicitly castable to the implementation type, but in value type you have to cast it manually or use the Value property.
The 1st commit is a Unit Test showcasing the problem