adding rest of the buildpacks and using npm to start the app

paketo-community · Jan 25, 2024 · f6a306f · f6a306f
1 parent 38093e8
commit f6a306f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/init_test.go b/init_test.go
@@ -81,6 +81,14 @@ func TestAcceptance(t *testing.T) {
 		Execute(settings.Config.BuildPlan)
 	Expect(err).ToNot(HaveOccurred())
 
+	settings.Buildpacks.NodeEngine.Online, err = buildpackStore.Get.
+		Execute(settings.Config.NodeEngine)
+	Expect(err).ToNot(HaveOccurred())
+
+	settings.Buildpacks.NPMInstall.Online, err = buildpackStore.Get.
+		Execute(settings.Config.NPMInstall)
+	Expect(err).ToNot(HaveOccurred())
+
 	buildImageID, runImageID, builderConfigFilepath, builderImageID, err = generateBuilder(root)
 	Expect(err).NotTo(HaveOccurred())
 

diff --git a/integration/testdata/nodejs_simple_app/package.json b/integration/testdata/nodejs_simple_app/package.json
@@ -3,7 +3,8 @@
   "version": "0.0.1",
   "description": "some app",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "start": "node server.js"
   },
   "author": "",
   "license": "",

diff --git a/integration/testdata/nodejs_simple_app/plan.toml b/integration/testdata/nodejs_simple_app/plan.toml
@@ -3,3 +3,9 @@
 
   [requires.metadata]
     launch = true
+
+[[requires]]
+  name = "node_modules"
+
+  [requires.metadata]
+    launch = true
diff --git a/nodejs_stack_integration_test.go b/nodejs_stack_integration_test.go
@@ -87,6 +87,8 @@ func testNodejsStackIntegration(t *testing.T, context spec.G, it spec.S) {
 						settings.Extensions.UbiNodejsExtension.Online,
 					).
 					WithBuildpacks(
+						settings.Buildpacks.NodeEngine.Online,
+						settings.Buildpacks.NPMInstall.Online,
 						settings.Buildpacks.BuildPlan.Online,
 					).
 					WithBuilder(builderImageID).
@@ -98,7 +100,7 @@ func testNodejsStackIntegration(t *testing.T, context spec.G, it spec.S) {
 
 				container, err = docker.Container.Run.
 					WithPublish("8080").
-					WithCommand("node server.js").
+					WithCommand("npm start").
 					Execute(image.ID)
 				Expect(err).NotTo(HaveOccurred())