-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding BP_UBI_RUN_IMAGE_OVERRIDE environment variable #76
Adding BP_UBI_RUN_IMAGE_OVERRIDE environment variable #76
Conversation
7cf5dbb
to
8098e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just need to add space after // in comment lines. Believe that is what is used in existing comments (at least from my look at the nodejs-engine)
d47b917
to
ba9adb2
Compare
…_RUN_IMAGE_OVERRIDE
7881dd2
to
0ecb6b7
Compare
ab22fce
to
0ecb6b7
Compare
@paketo-bot-reviewer Tests are failing as the #82 hasnt been merged yet. |
@pacostas this all makes sense to me. Happy to merge it in once the merge conflicts are resolved |
Merge After
@paketo-bot-reviewer
Summary
This PR introduces an new environment variable called
BP_UBI_RUN_IMAGE_OVERRIDE
. The purpose of this env variable, is to set the run image with the value ofBP_UBI_RUN_IMAGE_OVERRIDE
.On the generate phase of the extension, is specified which image should be set as a run image. With this PR, we are able to explicitly set the run image according to the value of
BP_UBI_RUN_IMAGE_OVERRIDE
. As a result if theBP_UBI_RUN_IMAGE_OVERRIDE
environment variable has been set and is not an empty string, the run image will have the value ofBP_UBI_RUN_IMAGE_OVERRIDE
otherwise is determined on how it used to be in the past, based on the node version.Use Cases
This change, helps us on setting run images without modifying the source code of the extension (the extension.toml file). E.x. when we release a new stack, we dont have the option to test the release candidate stack without modifying the source code of the extension, as the run image is not published yet to a registry. By explicitly specifying the run image with the
BP_UBI_RUN_IMAGE_OVERRIDE
, we are able to test that run image, before creating a release and pushing it to a registry.Checklist