Updating ReadMe instructions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Dec 18, 2023
README.md
Outdated
| environment variable at build time either directly (ex. `pack build my-app | ||
| --env BP_NODE_VERSION=~16`) or through a [`project.toml` | ||
| file](https://github.com/buildpacks/spec/blob/main/extensions/project-descriptor.md) | ||
| To specify the version of the Node that is installed, set the `$BP_NODE_VERSION` environment variable at build time either directly (ex. `pack build my-app --env BP_NODE_VERSION=~16`) or through a [`project.toml`file](https://github.com/buildpacks/spec/blob/main/extensions/project-descriptor.md) |
There was a problem hiding this comment.
I think we could add here that it can also be set through the package.json, ,npmrc file etc.
mhdawson
approved these changes
Dec 18, 2023
pacostas
force-pushed
the
updating-readme
branch
from
6f7d9fb to
76c6545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates instructions on how to build an app using ubi-nodejs-extension
Checklist